fix: append UUID to URL path for item-specific API calls#2
Open
chris6785 wants to merge 1 commit into
Open
Conversation
UUID parameters were not being appended to the URL path for methods
like getItem, setItem, delItem, causing API calls to fail.
The callModularTool method was passing the entire params object as a
single argument to client methods that expect individual positional
parameters. For example, aliasGetItem(uuid) received {uuid: "abc-123"}
instead of the string "abc-123", producing URLs like
/api/firewall/alias/get_item/[object Object].
Fix: Parse function parameter names from toString() and map the params
object values to positional arguments in the correct order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callModularToolwas passing the entire params object as a single argument to client methods that expect individual positional parameters (e.g.,uuid,name,data)aliasGetItem(uuid)received{uuid: "abc-123"}instead of the string"abc-123", producing URLs like/api/firewall/alias/get_item/[object Object]instead of/api/firewall/alias/get_item/abc-123toString()and map the params object values to positional arguments in the correct orderTest plan
aliasGetItem,aliasSetItem,aliasToggleItem,aliasGetAliasUUID,filterMoveRuleBefore,categoryDelItemfilterMoveRuleBefore(selectedUuid, targetUuid, data)) map correctly