fixing the position and adding animation to explore now button#560
Open
s2sharpit wants to merge 1 commit into
Open
fixing the position and adding animation to explore now button#560s2sharpit wants to merge 1 commit into
s2sharpit wants to merge 1 commit into
Conversation
Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lalitmee
suggested changes
Jul 29, 2023
Comment on lines
+75
to
+88
| <div className="fixed bottom-8 z-40 left-1/2 -translate-x-1/2 grid place-items-center w-max"> | ||
| <div className="absolute bg-black w-2/3 h-2/3 -z-10 rounded-full animate-ping"></div> | ||
| <Link href="/login" | ||
| className="flex items-center justify-center p-4 text-white duration-700 ease-out bg-black border-2 border-black rounded-full cursor-pointer w-fit h-fit dark:bg-zinc-50 hover:scale-110" | ||
| > | ||
| <h4 className="flex items-center text-xl font-archivo dark:text-zinc-800 space-x-3"> | ||
| <span className="hidden lg:block">Explore Courses</span> | ||
| <span className="lg:hidden">Get Started</span> | ||
| <span className="text-white material-icons dark:text-black"> | ||
| north_east | ||
| </span> | ||
| </h4> | ||
| </Link> | ||
| </div> |
There was a problem hiding this comment.
Instead of putting this directly in the index.tsx, I think we should create a component and then use that here. It would be more clean and maintainable in the long run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Closes: #549
Changes 💬
If something needs to be modified. Let me know.