Skip to content

fix:close-navmenu-outside#601

Open
URVESH1121 wants to merge 3 commits into
PiyushKalyanpy:mainfrom
URVESH1121:fix-close-navmenu-outside
Open

fix:close-navmenu-outside#601
URVESH1121 wants to merge 3 commits into
PiyushKalyanpy:mainfrom
URVESH1121:fix-close-navmenu-outside

Conversation

@URVESH1121
Copy link
Copy Markdown

Description 📝

Fixes/Closes: #600

Please provide a brief description of the purpose and goals of this pull request.

  • When user click outside the navmenu then navmenu will be close

Screenshots (if applicable)

Loom.Message.-.25.August.2023.mp4

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gyanaguru ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 11:57am

Comment thread src/components/landing/LandingNav.tsx Outdated
Copy link
Copy Markdown

@lalitmee lalitmee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if we can do the closing without using addEventListener

@URVESH1121
Copy link
Copy Markdown
Author

@lalitmee , I've submitted a pull request (#601) with some changes. Could you please take a look and let me know your thoughts? Your feedback would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Navmenu for mobile does not close on clicking outside of menu

2 participants