Skip to content

fix(area_management): [PPT-2384] JSON TypeCastError #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chillfox wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(area_management): [PPT-2384] JSON TypeCastError #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions drivers/place/area_management.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,16 +289,16 @@ class Place::AreaManagement < PlaceOS::Driver
protected def update_level_details(level_details, zone, metadata)
return unless zone.tags.includes?("level")

if desks = metadata["desks"]?
desks_meta = metadata["desks"]?
if desks_meta && (desk_array = desks_meta.details.as_a?)
desk_map = {} of String => String

if @desk_id_mappings.empty?
ids = desks.details.as_a.map { |desk| desk["id"].as_s }
ids = desk_array.map { |desk| desk["id"].as_s }
else
desk_details = desks.details.as_a
ids = Array(String).new(desk_details.size)
ids = Array(String).new(desk_array.size)

desk_details.each do |desk|
desk_array.each do |desk|
desk_id = desk["id"].as_s
ids << desk_id
@desk_id_mappings.each do |mapping|
Expand All @@ -309,14 +309,17 @@ class Place::AreaManagement < PlaceOS::Driver
end
end

ids = desks.details.as_a.map { |desk| desk["id"].as_s }
ids = desk_array.map { |desk| desk["id"].as_s }
level_details[zone.id] = {
total_desks: ids.size,
total_capacity: zone.capacity,
desk_ids: ids,
desk_mappings: desk_map,
}
else
if desks_meta
logger.debug { "desks metadata for zone #{zone.id} has unexpected format: expected Array, got #{desks_meta.details.raw.class}" }
Copy link
Member

@stakach stakach Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a warning

end
level_details[zone.id] = {
total_desks: zone.count,
total_capacity: zone.capacity,
Expand Down
Loading