Skip to content

kcontext: get rid of stdin/out/err #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omar-polo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

kcontext: get rid of stdin/out/err #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a462b
kcontext: get rid of stdin/out/err
omar-polo Dec 24, 2025
8e8c392
fixup
omar-polo Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions kcontext/kcontext.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ package kcontext

import (
"context"
"io"
"os"
"time"

"github.com/PlakarKorp/kloset/caching"
Expand All @@ -24,10 +22,6 @@ type KContext struct {
Context context.Context `msgpack:"-"`
Cancel context.CancelCauseFunc `msgpack:"-"`

Stdin io.Reader `msgpack:"-"`
Stdout io.Writer `msgpack:"-"`
Stderr io.Writer `msgpack:"-"`

Quiet bool
Silent bool

Expand Down Expand Up @@ -56,9 +50,6 @@ func NewKContext() *KContext {

return &KContext{
events: events.NewEventsBUS(0),
Stdin: os.Stdin,
Stdout: os.Stdout,
Stderr: os.Stderr,
Context: ctx,
Cancel: cancel,
}
Expand Down
5 changes: 0 additions & 5 deletions snapshot/exporter/exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ import (

type Options struct {
MaxConcurrency uint64

Stdout io.Writer
Stderr io.Writer
}

type LinkType int
Expand Down Expand Up @@ -74,8 +71,6 @@ func NewExporter(ctx *kcontext.KContext, config map[string]string) (Exporter, er

opts := &Options{
MaxConcurrency: uint64(ctx.MaxConcurrency),
Stdout: ctx.Stdout,
Stderr: ctx.Stderr,
}

return backend(ctx, opts, proto, config)
Expand Down
4 changes: 0 additions & 4 deletions snapshot/importer/importer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ type Options struct {
CWD string
MaxConcurrency int
Excludes []string

Stdin io.Reader `msgpack:"-"`
Stdout io.Writer `msgpack:"-"`
Stderr io.Writer `msgpack:"-"`
}

type ImporterFn func(context.Context, *Options, string, map[string]string) (Importer, error)
Expand Down
4 changes: 2 additions & 2 deletions testing/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ func GenerateContext(t *testing.T, bufout *bytes.Buffer, buferr *bytes.Buffer) *
// create a repository
ctx.MaxConcurrency = 1
if bufout != nil && buferr != nil {
ctx.Stdout = bufout
ctx.Stderr = buferr
// ctx.Stdout = bufout
// ctx.Stderr = buferr
}
cache := caching.NewManager(pebble.Constructor(tmpCacheDir))
ctx.SetCache(cache)
Expand Down
4 changes: 2 additions & 2 deletions testing/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ func GenerateRepository(t *testing.T, bufout *bytes.Buffer, buferr *bytes.Buffer
// create a repository
ctx.MaxConcurrency = 1
if bufout != nil && buferr != nil {
ctx.Stdout = bufout
ctx.Stderr = buferr
// ctx.Stdout = bufout
// ctx.Stderr = buferr
}
cache := caching.NewManager(pebble.Constructor(tmpCacheDir))
ctx.SetCache(cache)
Expand Down
Loading