locate: use a duration for before and since#369
Draft
omar-polo wants to merge 1 commit into
Draft
Conversation
omar-polo
marked this pull request as draft
May 8, 2026 15:36
Contributor
|
@op rebase |
This fixes a serialization issue of the policies in plakar, since we might want to be able to store a LocationOptions to the disk and apply it later while still preserving the information that before was really "30 days" and not the current timestamp minus 30 days.
omar-polo
force-pushed
the
op/locate-with-duration
branch
from
May 11, 2026 07:54
a033e61 to
bf07987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a serialization issue of the policies in plakar, since we might want to be able to store a LocationOptions to the disk and apply it later while still preserving the information that before was really "30 days" and not the current timestamp minus 30 days.