Skip to content

pkg create: add missing snap.Close() #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omar-polo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkg create: add missing snap.Close() #2206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions subcommands/pkg/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ func (cmd *PkgCreate) Execute(ctx *appcontext.AppContext, _ *repository.Reposito
return 1, fmt.Errorf("failed to commit snapshot: %w", err)
}

if err := snap.Close(); err != nil {
return 1, fmt.Errorf("failed to close snapshot: %w", err)
}

@mathieu-plak mathieu-plak Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This closes the scanCache, which is then used in CommitTransaction AFAIK to publish the delta state to teh repository. Am I missing something obvious?

@omar-polo omar-polo Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot some context in this, sorry.

this diff was before i discovered the issue on windows, when i was still searching for possible causes.

I was comparing pkg/create.go with subcommands/ptar and noticed the missing close, but it wasn't the fix obviously :)

in subcommands/ptar we do close the snap, look: https://github.com/PlakarKorp/plakar/blob/main/subcommands/ptar/ptar.go#L378-L381

// We are done with everything we can now stop the backup routines.
repoWriter.PackerManager.Wait()
err = repoWriter.CommitTransaction(identifier)
Expand Down
Loading