fix(mount): handle snapshot root path#2261
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
plakar mount -to <path> <snapshotID>when the selected snapshot path resolves to the snapshot root. The mount path preparation now keeps the full snapshot filesystem for/instead of callingfs.Subwith an empty path.Related to #2086
Why
A root snapshot selection can produce
/fromlocate.OpenSnapshotByPath; trimming that to an empty subpath makesfs.Subreturnsub : invalid argumentbefore the mount can proceed.Original issue repro status
I re-ran the exact issue steps on unmodified
origin/mainin Docker/Linux. The original symptom was not reproduced in this environment: the command got past thefs.Subpath and failed later at FUSE mount setup.Full repro log:
/tmp/see-real-bug_PlakarKorp-plakar_2086_rerun.log.So this PR should be treated as a targeted root-path regression fix, not as a fully confirmed reproduction of #2086 on Linux. The issue reporter reproduced on macOS; I do not have a macOS/FUSE environment here to confirm the original
plakar: sub : invalid argumentsymptom end-to-end.Regression proof (RED -> GREEN)
The regression test exercises the failing root-path branch directly.
RED, after temporarily removing the
/branch fromsnapshotSubFS:GREEN after restoring the fix:
Coverage added
Test plan
docker run --rm -v "$PWD":/src -v /tmp/plakar-go-cache:/go/pkg/mod -v /tmp/plakar-go-build:/root/.cache/go-build -w /src golang:1.25 go test ./subcommands/mount -run TestSnapshotSubFSRootPathUsesSnapshotRoot -count=1docker run --rm -v "$PWD":/src -v /tmp/plakar-go-cache:/go/pkg/mod -v /tmp/plakar-go-build:/root/.cache/go-build -w /src golang:1.25 go test ./subcommands/mount -count=1docker run --rm -v "$PWD":/src -v /tmp/plakar-go-cache:/go/pkg/mod -v /tmp/plakar-go-build:/root/.cache/go-build -w /src golang:1.25 sh -c 'go build -v ./... && go test ./...'Full validation result: