fix(restore): warn on snapshot backup errors#2262
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep restore successful when the restore operation itself succeeds, but emit a warning when the source snapshot contains backup-time errors.
Closes #1821
Why
The issue discussion settled on warning the user instead of making restore fail for errors that happened during backup. This makes the restore result clearer without changing the exit status for successfully restored available files.
Test verification (RED -> GREEN)
Original issue repro on unmodified
origin/main: create a plaintext repo, back up a tree as an unprivileged user with one unreadable file, then restore the resulting snapshot.RED - upstream restore exits 0 and emits no restore warning even though the snapshot contains a backup error:
Full repro log:
/tmp/see-real-bug_PlakarKorp-plakar_1821_confirmed.log.GREEN - patched branch warns while preserving a successful restore:
Secondary regression proof, after temporarily forcing the backup-error counter to return zero:
GREEN again after restoring the fix:
Coverage added
Test plan
docker run --rm -v "$PWD":/src -v /tmp/plakar-go-cache:/go/pkg/mod -v /tmp/plakar-go-build:/root/.cache/go-build -w /src golang:1.25 go test ./subcommands/restore -run TestRestoreWarnsWhenSnapshotContainsBackupErrors -count=1docker run --rm -v "$PWD":/src -v /tmp/plakar-go-cache:/go/pkg/mod -v /tmp/plakar-go-build:/root/.cache/go-build -w /src golang:1.25 go test ./subcommands/restore -count=1docker run --rm -v "$PWD":/src -v /tmp/plakar-go-cache:/go/pkg/mod -v /tmp/plakar-go-build:/root/.cache/go-build -w /src golang:1.25 sh -c 'go build -v ./... && go test ./...'Full validation result: