Tidyup - #19
Conversation
|
This all looks great. Could you please just explain what the linting workflow does/how it's used? Is this something that runs automatically on new commits? |
Format using the Ruff linter Organise import blocks Tidy up of miscellaneous Ruff linter check errors. Fix Yoda conditions Simplify if/else and return statements Remove unnecessary use of list on set sorts Reorder type hints Remove the unnecessary assignment of variables Replace use of open with Path.open for file handling Remove and ignore use of ambiguous variable names Remove unused assignment of variables Convert unused variables to underscore format Convert format calls on strings to f-strings Remove use of * imports and remove unused imports Remove use of * imports and update __all__
…sed commented-out code
The linter workflow will be ran when a contributor submits a Pull Request. It will run both the The workflow will run the commands in a virtual machine, not on the actual code of the repository (i.e it won't actually change any code). It will simply check for a non-zero exit code (i.e a problem found) and if one is found, the PR will be marked with a red cross. This would just mean the contributor should go and run the commands themselves, resolve any issues, and push again and hope for them to pass and give a green tick. :) |
2 participants
!! No actual code changes !!
Fixes issues #8, #9 and #13