Port controlled document changes#8
Merged
Merged
Conversation
Cherry-picked (partial) from intabia-fusion/platform@87f1a2674 Original-Author: Andrey Sobolev <haiodo@users.noreply.github.com> Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
requested review from
BykhovDenis,
aonnikov,
haiodo and
kristina-fefelova
July 10, 2026 11:28
ArtyomSavchenko
changed the title
aonnikov
approved these changes
Jul 10, 2026
ArtyomSavchenko
pushed a commit
that referenced
this pull request
Jul 21, 2026
Follow-up review fixes for the office/video port: - #5 guest-join room access (services/love guests.ts, workspaceClient.ts): enforce the room's live access server-side. A host who set the room to DND (locked) is no longer joinable via a previously shared guest link. Added WorkspaceClient.findRoomById and check the Room (not the meeting's creation-time snapshot). Knock rooms stay allowed — the shared link is the host's authorization. - #7 guest-info polling (GuestMeetingApp.svelte): fetch /guestInfo once per guest-token change instead of on every 1s tick, which POSTed the love service every second and re-ran workspace select/navigate each time. Also fixed the dead 'resolving' flag so the loading state and in-flight guard actually work. - #8 invite state machine (invites.ts, meetings.ts): * incoming invites now require status==='pending', so accepted/declined invites stop showing the button and knock sound during their TTL * knock-sound stop is guarded by incoming.length===0 (was inverted: stopped the sound while an invite was still pending) * connectToMeeting resets currentMeeting/currentMeetingRoom on any failure (connect error or unresolved person) so the guard no longer permanently blocks retry Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BZnVtCWH1hTH7EisaBdT7T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port controlled document changes:
file attachments copied when creating a document from a template and when drafting a new version (prior attachments carried over, except those marked deleted); attachment state tracking (referenced / deleted-in-version) + file preview in the document attachment list.
Original author: @haiodo