Skip to content

Conversation

@Undefined-User
Copy link
Contributor

@Undefined-User Undefined-User commented Sep 13, 2025

Some apps will freeze or crash when click close button if we send willTerminateNotification. The developer documentation says this is a "may be called method", so it can be safely skipped.
https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623111-applicationwillterminate

Related PR: #136

@TheMoonThatRises TheMoonThatRises added the enhancement New feature or request label Sep 13, 2025
@Undefined-User
Copy link
Contributor Author

PR is ready for review, but I can't add reviewer myself. @TheMoonThatRises @JoseMoreville

@Undefined-User
Copy link
Contributor Author

Now I try disable line_length check for apple document url, please review now~ @TheMoonThatRises @XuYicong

@TheMoonThatRises
Copy link
Member

I'm not sure that this should be commented out, as the developer documentation states that it may be called to terminate applications already in the background. I think more investigation into this would be necessary.

@Undefined-User
Copy link
Contributor Author

Undefined-User commented Oct 14, 2025

I'm not sure that this should be commented out, as the developer documentation states that it may be called to terminate applications already in the background. I think more investigation into this would be necessary.

@TheMoonThatRises I understand, you can feel free to test these IPA files and investigate the cause of the freeze or crash:

[IPA link1]: Install IPA and open it(maybe need disable keymapping), wait few seconds then click red close button in window, app will freeze and not responding now. No freezing status when using Cmd+Q key.

[IPA link2]: Install IPA and open it(maybe need disable keymapping), wait few seconds then click red close button in window, "App quit unexpectedly" crashing popup will show after few second. No crashing popup when using Cmd+Q key.

@Undefined-User
Copy link
Contributor Author

Undefined-User commented Oct 22, 2025

I'm not sure that this should be commented out, as the developer documentation states that it may be called to terminate applications already in the background. I think more investigation into this would be necessary.

@TheMoonThatRises I understand, you can feel free to test these IPA files and investigate the cause of the freeze or crash:

[IPA link1]: Install IPA and open it(maybe need disable keymapping), wait few seconds then click red close button in window, app will freeze and not responding now. No freezing status when using Cmd+Q key.

[IPA link2]: Install IPA and open it(maybe need disable keymapping), wait few seconds then click red close button in window, "App quit unexpectedly" crashing popup will show after few second. No crashing popup when using Cmd+Q key.

@TheMoonThatRises Hi~ do you have any new ideas for this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants