Skip to content

Create load.py - #4

Open
JosephPobega wants to merge 5 commits into
Pobega:masterfrom
JosephPobega:patch-1
Open

Create load.py#4
JosephPobega wants to merge 5 commits into
Pobega:masterfrom
JosephPobega:patch-1

Conversation

@JosephPobega

Copy link
Copy Markdown

in pygame

Comment thread pygame/load.py Outdated

@JosephPobega JosephPobega left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright sounds good thank you

change caption name for consistency throughout project

@Pobega Pobega left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include a setup.py to make this easier?

Comment thread pygame/load.py
@@ -0,0 +1,45 @@
# dvd logo simulator in python

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing shebang

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear what Python version this is meant to run on without the shebang line.

Comment thread pygame/load.py

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally could you please add execute permissions to this file?

@Pobega

Pobega commented Nov 15, 2023

Copy link
Copy Markdown
Owner

Doesn't run; fails to find dvd_logo.png.

pygame 2.5.2 (SDL 2.26.3, Python 3.11.6)
Hello from the pygame community. https://www.pygame.org/contribute.html
Traceback (most recent call last):
  File "/var/home/pobega/Code/DVD-Player-Simulator/pygame/load.py", line 17, in <module>
    dvd_logo = pygame.image.load("dvd_logo.png")  
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: No file 'dvd_logo.png' found in working directory '/var/home/pobega/Code/DVD-Player-Simulator/pygame'.

@Pobega

Pobega commented Nov 15, 2023

Copy link
Copy Markdown
Owner

I was able to get it to work by running processing/dvd_simulator/assets/dvd_logo.png into the pygame directory, a few thoughts on the featureset:

  1. The image appears to be moving at a crazy high speed. Could you please slow it down so it acts similarly to an actual DVD player screensaver? For reference: https://bouncingdvdlogo.com/
  2. The logo itself is supposed to change colors any time it touches a wall. Currently it appears to just stay the one solid white color.

Comment thread setup.py
'dvd_simulator = load:__main__',
],
},
author='Your Name',

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment thread load.py
Comment thread setup.py
],
entry_points={
'console_scripts': [
'dvd_simulator = load:__main__',

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this - there's no dvd_simulator, and it doesn't have a __main__ function as an entrypoint. Wouldn't this fail?

@Pobega

Pobega commented Nov 17, 2023

Copy link
Copy Markdown
Owner

Why are there two load.py files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants