Open
Conversation
Author
|
this does not solve the whole problem, still some edge cases can appear where not a sufficient number of SNPs (more than 1 but less than 3?) is present to calculate correlations, some threshold of a minimal number of SNPs are needed. |
|
I have encountered this bug. Can this fix be merged into the official repository? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for samples with a low read depth, it can happen that no SNP/variant is found per sample and the
vafcolumn inrc_afcontains only NAs.This causes problems in
cor.test()codeline with one argument only containing NAs when iterating over allparallel::mclapply(seq_along(rc_af), function(idx)codeline-> simple fix with filtering beforehand for only selected samples containing SNPS which passed the
min_depthrequirement. also include output information about samples which have been ignored (also this could theoretically extracted by the user from the difference ofSNP_readcounts$BAMandcolnames(AF_table)but makes it clearer)feel free to edit, was only a fast easy fix,
it is a really nice method