Circle ROIs, ROIs dimension selector and batch processing of videos#22
Circle ROIs, ROIs dimension selector and batch processing of videos#22Snapyou2 wants to merge 7 commits into
Conversation
…nction to process a lot of data at once, with support for a different shape for each video
|
looks good. Some small changes
Thank you for your update! |
|
Alright, thanks for feedback. I'll work on these improvements after my exam session, around 2 weeks from now. |
|
I have added your remarks into this PR, everything should be ok (had a lot of troubles with the README formatting haha, but it should be alright now). |
cd5edb5 to
b4c0186
Compare
|
great :) I see you've made more commits, let me know when it's ready for me to review and I will. |
|
Would it be possible to include the mp4 you used for drawing the shape? Totally understandable if not! |
|
Also wondering whether you would be interested in pursuing a submission to the Journal of Open Source software? I would be really happy for you to be first author and me last. It may also require a couple more features (Not as part of this pull request). Let me know if this is something you think would be worthwhile :) |
|
I could join the mp4 (maybe not the full one though, it is quite heavy), but I do not know what it would add really to the project except a few megabytes ? Maybe for demonstrative/tutorial purposes ? |
|
I think the aesthetic changes are great. I think the mp4 would be nice for testing the roi drawing functions but its not necessary. I'll review this this week and merge it. Thanks for your efforts! |
|
OK just tried to test without a video and hit an error. I think we need the video to test (a couple seconds is enough). The steps I took were
This results in the error This error may be due to having no video, however this isn't possible in the original DLC ROI Tool as it forces the user to open a video when the program launches. This will require one of two changes.
|
I added the ability to use circles as ROIs, change the size in pixel of the ROIs, and also added a batch function to process multiple videos at once, with support for a different ROI shape for each video