fix: hide credential validation test switch#40
Merged
cesarenaldi merged 2 commits intoMay 25, 2026
Conversation
DEV-123 Hide credential validation test switch from Python SDK public API
Remove |
87af5eb
into
feature/dev-118-open-source-the-python-sdk-repository
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: DEV-123
Summary:
Verification:
Note
Low Risk
Public construction still validates credentials by default; only the documented factory surface and test call sites change.
Overview
Removes
validate_credentialsfrom the publicSecureClient.createandAsyncSecureClient.createsignatures so callers can no longer skip API credential checks at construction time. The real factory logic moves to private_create, which still supportsvalidate_credentials; publiccreatealways delegates with validation enabled (True).Unit and integration tests that need fake credentials without a live auth probe now call
_create(..., validate_credentials=False)instead of the public factory. A new test assertsvalidate_credentialsis absent from the publiccreatesignatures viainspect.signature.Default behavior for SDK users is unchanged: provided credentials are still validated unless tests use the private path.
Reviewed by Cursor Bugbot for commit 78a2228. Bugbot is set up for automated code reviews on this repo. Configure here.