Skip to content

feat(client): default secure clients to deposit wallet#67

Open
cesarenaldi wants to merge 2 commits into
mainfrom
dev-157
Open

feat(client): default secure clients to deposit wallet#67
cesarenaldi wants to merge 2 commits into
mainfrom
dev-157

Conversation

@cesarenaldi
Copy link
Copy Markdown
Collaborator

@cesarenaldi cesarenaldi commented Jun 4, 2026

Summary

  • default omitted secure-client wallets to the current deterministic Deposit Wallet
  • move Deposit Wallet deployment into public secure-client creation and make deprecated gasless helpers no-op shims
  • make trading approval setup idempotent and wait internally before returning a compatibility handle
  • align Python tests with TS SDK coverage, favoring integration coverage for the public omitted-wallet flow

Verification

  • uv run pytest tests/unit
  • uv run pytest tests/integration/test_relayer_approve_live.py -q
  • uv run ruff check .
  • uv run ruff format --check .
  • uv run pyright

Note

High Risk
Changes default wallet resolution, on-chain approval behavior, and create-time relayer deployment—behavioral breaking changes for integrators who relied on EOA defaults or async setup_gasless_wallet flows.

Overview
Secure clients now default an omitted wallet to the signer’s current Deposit Wallet (derived via RPC), not the EOA. create() runs _ensure_wallet_ready(), which deploys the default deposit wallet via the relayer when needed; invalid or non-deployed explicit wallets raise UserInputError.

Trading approvals are centralized in resolve_missing_trading_approval_calls: on-chain allowance / isApprovedForAll checks skip already-set approvals. setup_trading_approvals() waits for submitted txs internally and returns a DeprecatedTransactionHandle whose wait() is a no-op.

setup_gasless_wallet() and is_gasless_ready() are deprecated shims (return self / True). Relayer calls gains read/decode helpers; normalize_specs is public. Tests drop old gasless-setup units and cover idempotent approvals and deposit-wallet defaults.

Reviewed by Cursor Bugbot for commit e860c0d. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant