feat(client): default secure clients to deposit wallet#67
Open
cesarenaldi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
High Risk
Changes default wallet resolution, on-chain approval behavior, and create-time relayer deployment—behavioral breaking changes for integrators who relied on EOA defaults or async setup_gasless_wallet flows.
Overview
Secure clients now default an omitted
walletto the signer’s current Deposit Wallet (derived via RPC), not the EOA.create()runs_ensure_wallet_ready(), which deploys the default deposit wallet via the relayer when needed; invalid or non-deployed explicit wallets raiseUserInputError.Trading approvals are centralized in
resolve_missing_trading_approval_calls: on-chainallowance/isApprovedForAllchecks skip already-set approvals.setup_trading_approvals()waits for submitted txs internally and returns aDeprecatedTransactionHandlewhosewait()is a no-op.setup_gasless_wallet()andis_gasless_ready()are deprecated shims (returnself/True). Relayercallsgains read/decode helpers;normalize_specsis public. Tests drop old gasless-setup units and cover idempotent approvals and deposit-wallet defaults.Reviewed by Cursor Bugbot for commit e860c0d. Bugbot is set up for automated code reviews on this repo. Configure here.