DEV-203 Clear RFQ session cache on disconnect#89
Conversation
…related-error-frames' into feature/dev-203-clear-cached-rfq-session-immediately-on-websocket-disconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Stacked on: #88
Linear: DEV-203
Note
Medium Risk
Changes RFQ websocket session lifecycle and reconnect behavior in a trading path; scope is small and covered by a new integration test.
Overview
Fixes RFQ quoter reconnect after an unexpected websocket close by not reusing a dead cached session.
RfqQuoterWebSocketManager.connect()now drops the cached session when it is closing/closed and opens a new one instead of returning the stale handle.RfqWebSocketSessionexposes aclosedflag for that check. On socket close,#handleCloseinvokes the manager’sonClosecallback before async shutdown so the cache is cleared synchronously when the connection drops.Adds an integration test that quotes, forces the server to close mid-flight, then
openRfqSession()again and expects a new session and a second connection.Reviewed by Cursor Bugbot for commit d682421. Bugbot is set up for automated code reviews on this repo. Configure here.