ci: replace workflow_run chain with reusable verify call#9
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolves a CodeQL critical alert (actions/untrusted-checkout) by removing the workflow_run trigger and dynamic SHA checkout from release.yml. The release workflow now triggers on push to main and calls verify.yml directly as a required job, matching the pattern used in the Aave v4 SDK. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Extracts pull_request trigger into a dedicated pull-request.yml that calls verify.yml as a reusable workflow. verify.yml now only responds to workflow_call and workflow_dispatch, keeping trigger ownership clear. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…y on PRs Adds workflow_call trigger to tests.yml and removes the pull_request trigger. pull-request.yml now calls both verify and tests, with secrets: inherit so test credentials are available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ull-request Removes name fields from jobs in verify.yml and tests.yml to avoid redundant "Verify / Verify" status check labels. Adds permissions block to pull-request.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Status checks now read Verify / Run and Tests / Run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tests now run in release after verify succeeds but do not gate the Publish Canary step. Removes the standalone push-to-main trigger from tests.yml since release now owns that responsibility. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8346517. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify.ymla reusable workflow by adding theworkflow_calltriggerworkflow_runtrigger inrelease.ymlwithpushtomainverify.ymldirectly as a required job before publishing, matching the pattern used in the Aave v4 SDKWhy
The previous setup triggered release via
workflow_run, which required checking out a dynamic SHA (github.event.workflow_run.head_sha) in a job withid-token: write. CodeQL flagged this as a critical alert (actions/untrusted-checkout) — potential execution of untrusted code in a privileged context.The new setup eliminates the dynamic SHA entirely. The release workflow only fires on push to
main, checks outHEADwith no ref override, and guarantees verify passes before publishing.Reviewer notes
verify.ymlis unchanged in behaviour —workflow_callis additive alongside the existingpull_request/push/workflow_dispatchtriggersmainshould be resolved once this mergesNote
Medium Risk
Changes the GitHub Actions trigger and dependency graph for release/pull-request CI, which can affect when releases publish and whether checks gate them correctly. While mostly workflow wiring, mistakes could block or prematurely run canary publishing on
main.Overview
Adds a dedicated
pull-requestworkflow that runsverify.ymlandtests.ymlvia reusable workflow calls with per-PR concurrency.Refactors
release.ymlto trigger onpushtomain(dropping the priorworkflow_runchain and conditional/dynamic SHA checkout), and gates canary publishing behind a requiredverifyjob (and a dependenttestsjob).Updates
verify.ymlandtests.ymlto be reusable (workflow_call) and simplifies their job naming, and adds a couple of CI-related guardrails toAGENTS.md.Reviewed by Cursor Bugbot for commit 8346517. Bugbot is set up for automated code reviews on this repo. Configure here.