fix(client): default listEvents to open events#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closed=falsewhen callers omitclosedFixes #75
Linear: DEV-169
Verification
Note
Medium Risk
Changes default query behavior for existing callers who omitted
closed, which can break assumptions about which events are returned.Overview
listEventsnow treats omittedclosedas open-only events by applyingclosed: falseinListEventsRequestSchemainstead of leaving the filter unset.JSDoc on the low-level
listEventsaction and the discovery client’slistEventsmethod documents that default and notes thatclosed: trueis required for settled events. A patch changeset records the@polymarket/clientrelease note.Callers who previously omitted
closedand relied on the API returning both open and settled events will see narrower results unless they passclosed: true(or adjust filters explicitly).Reviewed by Cursor Bugbot for commit ca675ff. Bugbot is set up for automated code reviews on this repo. Configure here.