Skip to content

fix(client): default listEvents to open events#96

Merged
cesarenaldi merged 2 commits into
mainfrom
fix/dev-169-listevents-default-open
Jun 5, 2026
Merged

fix(client): default listEvents to open events#96
cesarenaldi merged 2 commits into
mainfrom
fix/dev-169-listevents-default-open

Conversation

@cesarenaldi
Copy link
Copy Markdown
Collaborator

@cesarenaldi cesarenaldi commented Jun 5, 2026

Summary

  • default listEvents requests to closed=false when callers omit closed
  • document the default on the action and bound client method
  • add a patch changeset for @polymarket/client

Fixes #75
Linear: DEV-169

Verification

  • pnpm lint
  • pnpm typecheck

Note

Medium Risk
Changes default query behavior for existing callers who omitted closed, which can break assumptions about which events are returned.

Overview
listEvents now treats omitted closed as open-only events by applying closed: false in ListEventsRequestSchema instead of leaving the filter unset.

JSDoc on the low-level listEvents action and the discovery client’s listEvents method documents that default and notes that closed: true is required for settled events. A patch changeset records the @polymarket/client release note.

Callers who previously omitted closed and relied on the API returning both open and settled events will see narrower results unless they pass closed: true (or adjust filters explicitly).

Reviewed by Cursor Bugbot for commit ca675ff. Bugbot is set up for automated code reviews on this repo. Configure here.

@cesarenaldi cesarenaldi changed the title Default listEvents to open events fix(client): default listEvents to open events Jun 5, 2026
@cesarenaldi cesarenaldi merged commit c188742 into main Jun 5, 2026
8 checks passed
@cesarenaldi cesarenaldi deleted the fix/dev-169-listevents-default-open branch June 5, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discovery: listEvents omits closed by default — first-page result is dominated by settled events

1 participant