Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dev-166-builder-fee-404.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@polymarket/client": patch
---

Map unknown builder fee responses to `UserInputError`.
12 changes: 11 additions & 1 deletion packages/client/src/actions/clob.ts
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,17 @@ export async function fetchBuilderFeeRates(
return unwrap(
client.clob
.get(`/fees/builder-fees/${params.builderCode}`)
.andThen(validateWith(FetchBuilderFeeRatesResponseSchema)),
.andThen(validateWith(FetchBuilderFeeRatesResponseSchema))
.mapErr((error) => {
if (error instanceof RequestRejectedError && error.status === 404) {
return new UserInputError(
`Unknown builder code: ${params.builderCode}`,
{ cause: error },
);
}

return error;
}),
);
}

Expand Down
26 changes: 25 additions & 1 deletion packages/client/tests/integration/orders.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { OrderSide, OrderType } from '@polymarket/bindings';
import { BuilderCodeSchema, OrderSide, OrderType } from '@polymarket/bindings';
import { OrderPostStatus } from '@polymarket/bindings/clob';
import {
createSecureClient,
InsufficientLiquidityError,
type Market,
type SecureClient,
UserInputError,
} from '@polymarket/client';
import { fetchNegRisk } from '@polymarket/client/actions';
import { expectPresent } from '@polymarket/types';
Expand All @@ -20,6 +21,9 @@ import { expectAcceptedOrderResponse } from './helpers';
import { findHighVolumeLowPriceMarket } from './markets';

const market = await findHighVolumeLowPriceMarket(publicClient);
const UNKNOWN_BUILDER_CODE = BuilderCodeSchema.parse(
'0xabcdefabcdefabcdefabcdefabcdefabcdefabcdefabcdefabcdefabcdefabcd',
);
let marketOrderCleanup:
| {
market: Market;
Expand Down Expand Up @@ -168,6 +172,26 @@ describe('Orders', { timeout: 60_000 }, () => {

expect(order.builder).toBe(builderCode);
});

it('reports unknown builder codes as user input errors when resolving buy amounts against max spend', async ({
annotate,
secureClientWithDepositWallet,
}) => {
const yesTokenId = expectPresent(market.outcomes.yes.tokenId);
const minimumOrderSize = expectPresent(market.trading.minimumOrderSize);
annotate(`Market ID: ${market.id}`);
annotate(`Token ID: ${yesTokenId}`);

await expect(
secureClientWithDepositWallet.createMarketOrder({
amount: minimumOrderSize,
builderCode: UNKNOWN_BUILDER_CODE,
maxSpend: minimumOrderSize,
side: OrderSide.BUY,
tokenId: yesTokenId,
}),
).rejects.toThrow(UserInputError);
});
});

describe('placeLimitOrder', () => {
Expand Down
Loading