fix(client): accept copied event market URLs#99
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a75a6fd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
/event/{slug}infetchMarket(url: ...)/event/{eventSlug}/{marketSlug}by using the final slugVerification
pnpm lintpnpm typecheckpnpm test:client:integration packages/client/tests/integration/markets.test.tsNote
Low Risk
Localized URL parsing for market lookup only; no auth or API contract changes beyond accepting additional user input shapes.
Overview
fetchMarket({ url })now accepts Polymarket links copied from the site that use the/event/...path, not only/market/{slug}.parsePolymarketSlugUrlgains a market-specific branch: when resolving a market,/event/{slug}uses that segment as the market slug, and/event/{eventSlug}/{marketSlug}prefers the second segment when present (at most one extra path segment). Other shapes still fail withUserInputError. Docs/examples and the integration test were updated to use event-style URLs; the negative test now rejects a tag URL instead of a plain event URL.Reviewed by Cursor Bugbot for commit a75a6fd. Bugbot is set up for automated code reviews on this repo. Configure here.