Skip to content
This repository was archived by the owner on Dec 28, 2024. It is now read-only.

Disabled items can't be selected#107

Open
reinert wants to merge 1 commit into
PolymerElements:masterfrom
reinert:disabled_items_not_selectable
Open

Disabled items can't be selected#107
reinert wants to merge 1 commit into
PolymerElements:masterfrom
reinert:disabled_items_not_selectable

Conversation

@reinert

@reinert reinert commented Feb 10, 2016

Copy link
Copy Markdown
Contributor

This is an initial proposed solution for #99.

Basically it prevents select method to set a disabled item as selected. Also selectNext and selectPrevious are covered: they try to find the nearest enabled item. These three methods now return true if an item was selected or false otherwise.

Not covered situations yet:

  • When selected property is manually changed
  • When a selected item becomes disabled

@reinert

reinert commented Feb 10, 2016

Copy link
Copy Markdown
Contributor Author

Also, should there be a feature toggle like skipDisabledItems allowing the user to decided whether disable items should be selectable or not?

@bicknellr

Copy link
Copy Markdown
Contributor

Hey, just wanted to let you know this PR hasn't gone unnoticed and we'll get to it soon. Ping me here if 'soon' stops being accurate.

@reinert

reinert commented Feb 17, 2016

Copy link
Copy Markdown
Contributor Author

Ok. I will.

@reinert

reinert commented Feb 18, 2016

Copy link
Copy Markdown
Contributor Author

Idea: provide an attr-for-disabled option so the user can determine what attribute will be queried to check the disabled state. Default value, obviously, would be 'disabled'.

@bicknellr

Copy link
Copy Markdown
Contributor

btw, I was poking around in paper-radio-group and found that it also implements this: https://github.com/PolymerElements/paper-radio-group/blob/3ee7a79/paper-radio-group.html#L164

@reinert

reinert commented Feb 20, 2016

Copy link
Copy Markdown
Contributor Author

Good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants