Align recommendation limitations with analysis maturity#122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_recommend_holdingwith conservative wording that states the deterministic status is derived from valuation, allocation, unrealized P/L, and risk warnings while optional technical/fundamental/news inputs exist but are not yet authoritative drivers. (seesrc/finwall/recommendations.py).cash deployment is based on valuation completeness, cash allocation, and risk warnings; optional technical/fundamental/news inputs are not used to generate ticker-level buy candidates in this rule set(seesrc/finwall/recommendations.py)._analysis_input_limitations()to centralize input-maturity wording and used it in_build_limitations()to replace the previous hard-coded "not implemented" limitation lines (seesrc/finwall/recommendations.py).README.md,docs/product-modes.md,docs/safety-limits.md).tests/test_recommendations.py,tests/test_reports.py).Testing
poetry run ruff check .andpoetry run ruff format --check --line-length 88 ., both succeeded.poetry run pytest, which passed (all tests including new regressions succeeded).Codex Task