Skip to content

Feature/143 improve product ux around setup login and empty states#173

Merged
PooriaT merged 8 commits into
mainfrom
feature/143-improve-product-ux-around-setup-login-and-empty-states
Jun 24, 2026
Merged

Feature/143 improve product ux around setup login and empty states#173
PooriaT merged 8 commits into
mainfrom
feature/143-improve-product-ux-around-setup-login-and-empty-states

Conversation

@PooriaT

@PooriaT PooriaT commented Jun 24, 2026

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e27849c06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +195 to +196
if (normalized === "unavailable" || normalized === "missing_prices") {
return "unavailable";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle legacy missing prices as unavailable

When the chart payload falls back to legacy price_completeness_status, the backend's snapshot code uses "missing" when holdings have no available prices, not "missing_prices". In that scenario this branch falls through to normalizeAvailability() and renders the dashboard as Unknown instead of the actionable Unavailable state, so missing-price dashboards get the wrong readiness status.

Useful? React with 👍 / 👎.

Comment thread apps/web/src/features/dashboard/OnboardingChecklist.tsx Outdated
@PooriaT PooriaT merged commit 4b92c73 into main Jun 24, 2026
1 check passed
@PooriaT PooriaT deleted the feature/143-improve-product-ux-around-setup-login-and-empty-states branch June 24, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setup health panel to the frontend Improve product UX around setup, login, and empty states

1 participant