Harden server startup and live-mode WebSocket behavior#1
Open
Popidge wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
server.listen(...callback...)handling with event-drivenlistening/errorlogic and a configurablemaxPortretry range by introducinglistenOnPortand normalizing numeric port parsing.express.json({ limit: '100kb')), validatingPOST /api/sharepayloads, and exposing aGET /api/configendpoint with runtime metadata.wss.on('error')handler and safer broadcast logic to avoid unhandled crashes.servemode, setCache-Control: no-storeon the injected shim to avoid stale config, and ensure the tester server is stopped when Vite shuts down.:3001, deduplicate URLs, and add explicit reconnect control viashouldReconnectRefwithstartLiveMode/disconnectWebSockethelpers.Testing
npm run build, which completed successfully.new WebShareTesterServer({ port: 3101, maxPort: 3103 }), which started and stopped successfully.3201and starting the server with{ port: 3201, maxPort: 3203 }, which logged the port busy message and successfully fell back to3202.Codex Task