perf(engine): skip ignored directories before descending into them - #34
Merged
Conversation
PopovVA
added a commit
that referenced
this pull request
Jul 17, 2026
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.1...v0.6.0) (2026-07-17) ### Features * **sd001:** detect secrets in map entries, parameter defaults and named arguments ([#36](#36)) ([6658f0a](6658f0a)), closes [#33](#33) ### Bug Fixes * **rules:** locate() skips matches inside XML comments ([#35](#35)) ([a429cac](a429cac)), closes [#32](#32) ### Performance Improvements * **engine:** skip ignored directories before descending into them ([#34](#34)) ([2911ae9](2911ae9)), closes [#31](#31) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_discoverusedlistSync(recursive: true), which walks the entire tree — including.git,.dart_tool,build,node_modules— and materializes the full file list in memory before any filtering happens. On large repositories this wastes time and memory for entries that are always discarded.Discovery now walks one directory level at a time and skips ignored directories before descending into them. Files are still yielded lazily; per-level sorting keeps discovery deterministic, and findings are re-sorted globally in
audit(), so report order is unchanged.Test
The new engine test locks a subdirectory of
.gitwithchmod 000: the old flat recursive listing throws on it before filtering (verified — the test fails on the previous implementation), while the new walk never enters.gitat all.Closes #31