fix(rules): locate() skips matches inside XML comments - #35
Merged
Conversation
PopovVA
added a commit
that referenced
this pull request
Jul 17, 2026
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.1...v0.6.0) (2026-07-17) ### Features * **sd001:** detect secrets in map entries, parameter defaults and named arguments ([#36](#36)) ([6658f0a](6658f0a)), closes [#33](#33) ### Bug Fixes * **rules:** locate() skips matches inside XML comments ([#35](#35)) ([a429cac](a429cac)), closes [#32](#32) ### Performance Improvements * **engine:** skip ignored directories before descending into them ([#34](#34)) ([2911ae9](2911ae9)), closes [#31](#31) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locate()recovered positions with a plaincontent.indexOf(needle). If a commented-out copy of a setting appeared earlier in the file (e.g.<!-- android:debuggable="true" -->above the active attribute), the finding pointed at the comment line instead of the active node.The rule semantics were never affected — they come from the parsed XML DOM, so no false positives or negatives — but the wrong line confuses users and destabilizes baseline fingerprints, which hash the finding's line text.
locate()now walks matches in order and skips any that sit inside an unclosed<!--. One deliberate trade-off: if the only raw-text match lives in a comment (active setting formatted differently), the position is nownullrather than wrong.Tests
SD005 (plist) and SD006 (manifest) get a case where a commented-out copy precedes the active setting; both assert the reported line is the active one. Both fail on the previous implementation (line 2 instead of 3).
Closes #32