feat(sd001): detect secrets in map entries, parameter defaults and named arguments - #36
Merged
Conversation
analyzer 14 renamed NamedExpression to NamedArgument and replaced DefaultFormalParameter with a default clause nested in the parameter, so the typed visitors did not compile there. The visitor now matches the shape of the literal's parent node instead of naming the renamed classes, keeping one code path for the whole supported range.
PopovVA
added a commit
that referenced
this pull request
Jul 17, 2026
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.1...v0.6.0) (2026-07-17) ### Features * **sd001:** detect secrets in map entries, parameter defaults and named arguments ([#36](#36)) ([6658f0a](6658f0a)), closes [#33](#33) ### Bug Fixes * **rules:** locate() skips matches inside XML comments ([#35](#35)) ([a429cac](a429cac)), closes [#32](#32) ### Performance Improvements * **engine:** skip ignored directories before descending into them ([#34](#34)) ([2911ae9](2911ae9)), closes [#31](#31) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The high-entropy detector in SD001 only looked at variable declarations, so secrets bound through other syntax were missed. The known-format detector (AWS keys, Stripe keys, PEM blocks, …) already scans every string literal and was never affected — this closes the gap in the name-plus-entropy heuristic only.
_SecretDeclarationVisitornow also collects:'dbPassword': '…') and identifier keys (dbPassword: '…');void connect({String apiKey = '…'});connect(apiKey: '…'), the same leak shape at the call site.All candidates go through the existing entropy / length / placeholder filters, so the noise profile is unchanged. Finding messages now name the binding context (
Variable 'x',Map entry 'x',Parameter 'x',Argument 'x').Tests
The vulnerable fixture gains one case per new context (all flagged); the clean fixture gains the same contexts with placeholder, low-entropy and unrelated-name values (all quiet). Verified clean against the analyzer lower bound (
dart pub downgrade+ analyze).Closes #33