Skip to content

Remove -Werror from autotools/darwin build, enable it on CI for all platforms #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veprbl wants to merge 2 commits into from
Closed

Remove -Werror from autotools/darwin build, enable it on CI for all platforms #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa9ff8
remove -Werror from autotools/darwin build
veprbl Aug 30, 2021
1677998
Add -Werror to CFLAGS and CXXFLAGS for CI workflows
veprbl Sep 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/autotools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ jobs:

runs-on: ubuntu-latest
name: Ubuntu
env:
CFLAGS: "-Werror"
CXXFLAGS: "-Werror"
Comment thread
veprbl marked this conversation as resolved.

steps:
- uses: actions/checkout@v2
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
cmake_options:
-DPA_USE_OSS=ON
-DCMAKE_TOOLCHAIN_FILE=vcpkg/scripts/buildsystems/vcpkg.cmake
werror_flags: "-Werror"

@Be-ing Be-ing Sep 11, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in CMakeLists.txt for ${CMAKE_BUILD_TYPE} STREQUAL "Debug" and change the cmake_build_type variable in this GH Actions workflow file to Debug.

@RossBencina RossBencina Oct 7, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI builds should use -Werror for both debug and release builds.

- name: Ubuntu MinGW
os: ubuntu-latest
install_dir: ~/portaudio
Expand All @@ -29,6 +30,7 @@ jobs:
-DPA_USE_ASIO=ON
-DASIO_SDK_ZIP_PATH=asiosdk.zip
-DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/i686-w64-mingw32.cmake
werror_flags: "-Werror"
- name: Windows MSVC
os: windows-latest
install_dir: C:\portaudio
Expand All @@ -42,6 +44,7 @@ jobs:
-DPA_USE_ASIO=ON
-DASIO_SDK_ZIP_PATH="asiosdk.zip"
-DCMAKE_TOOLCHAIN_FILE=D:\a\portaudio\portaudio\vcpkg\scripts\buildsystems\vcpkg.cmake
werror_flags: "" # TODO: use "/WX"
- name: Windows MinGW
os: windows-latest
install_dir: C:\portaudio
Expand All @@ -55,6 +58,7 @@ jobs:
-DPA_USE_ASIO=ON
-DASIO_SDK_ZIP_PATH="asiosdk.zip"
-DCMAKE_TOOLCHAIN_FILE=D:\a\portaudio\portaudio\vcpkg\scripts\buildsystems\vcpkg.cmake
werror_flags: "-Werror"
- name: macOS Clang
os: macOS-latest
install_dir: ~/portaudio
Expand All @@ -63,6 +67,7 @@ jobs:
cmake_options:
-DCMAKE_FRAMEWORK=OFF
-DCMAKE_TOOLCHAIN_FILE=vcpkg/scripts/buildsystems/vcpkg.cmake
werror_flags: "-Werror"
- name: macOS Clang framework
os: macOS-latest
install_dir: ~/portaudio
Expand All @@ -71,11 +76,14 @@ jobs:
cmake_options:
-DCMAKE_FRAMEWORK=ON
-DCMAKE_TOOLCHAIN_FILE=vcpkg/scripts/buildsystems/vcpkg.cmake
werror_flags: "-Werror"

runs-on: ${{ matrix.os }}
name: ${{ matrix.name }}
env:
cmake_build_type: RelWithDebInfo
CFLAGS: ${{ matrix.werror_flags }}
CXXFLAGS: ${{ matrix.werror_flags }}
steps:
- name: checkout Git repository
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15866,7 +15866,7 @@ case "${host_os}" in
$as_echo "#define PA_USE_COREAUDIO 1" >>confdefs.h


CFLAGS="$CFLAGS -I\$(top_srcdir)/src/os/unix -Wno-deprecated -Werror"
CFLAGS="$CFLAGS -I\$(top_srcdir)/src/os/unix -Wno-deprecated"
LIBS="-framework CoreAudio -framework AudioToolbox -framework AudioUnit -framework CoreFoundation -framework CoreServices"

if test "x$enable_mac_universal" = "xyes" ; then
Expand Down
2 changes: 1 addition & 1 deletion configure.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ case "${host_os}" in

AC_DEFINE(PA_USE_COREAUDIO,1)

CFLAGS="$CFLAGS -I\$(top_srcdir)/src/os/unix -Wno-deprecated -Werror"
CFLAGS="$CFLAGS -I\$(top_srcdir)/src/os/unix -Wno-deprecated"
LIBS="-framework CoreAudio -framework AudioToolbox -framework AudioUnit -framework CoreFoundation -framework CoreServices"

if test "x$enable_mac_universal" = "xyes" ; then
Expand Down