fix: localise query replacements to url#5
Open
TrebledJ wants to merge 2 commits into
Open
Conversation
Instead of mass replacing the URL path in the entire request, replace only the path in the first HTTP line. The fix here reuses the same pattern seen in other functions in this extension.
…P/1.1` (when requesting) and the one in `https://...` (when reporting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of mass replacing the URL path in the entire request, replace only the path in the first HTTP line. The fix here reuses the same pattern seen in other functions in this extension.
I've also isolated the makeHttpRequest call inside the try-block, to avoid conflating with possible exceptions in buildHttpRequest and other functions. In those other cases, we want exceptions to happen to see the error.