Skip to content

Replace UI Tests with significantly faster and thorough Integration Tests #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PortoCode merged 13 commits into from
Mar 6, 2025
Merged

Replace UI Tests with significantly faster and thorough Integration Tests #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7b1c0f3
Configures feed navigation as window root view controller
PortoCode Mar 3, 2025
c771a2f
Move Feed UI composition details from the EssentialFeediOS to the Ess…
PortoCode Mar 6, 2025
3c32abc
Displays remote feed on launch when customer has connectivity
PortoCode Mar 6, 2025
04e05d0
Displays cached feed on launch when customer has no connectivity
PortoCode Mar 6, 2025
793a61c
Displays empty feed on launch when customer has no connectivity and n…
PortoCode Mar 6, 2025
4cdc184
Check number of cells before fetching cell at index to avoid out of b…
PortoCode Mar 6, 2025
eb039c8
Remove EssentialAppUIAcceptanceTests in favor of faster and more prec…
PortoCode Mar 6, 2025
4fb91c4
Remove unused debugging code that was previously used during UI tests
PortoCode Mar 6, 2025
66c1f7f
Validate feed cache on entering background
PortoCode Mar 6, 2025
17f6d27
Move `HTTPClientStub` to a shared scope in a separate file
PortoCode Mar 6, 2025
6d89012
Move `InMemoryFeedStore` to a shared scope in a separate file
PortoCode Mar 6, 2025
6454e3d
Improve launch method on FeedAcceptanceTests
PortoCode Mar 6, 2025
6e5d83a
Load feed actions runs automatically only on first appearance
PortoCode Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions EssentialApp/CI_iOS.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,6 @@
"identifier" : "5BDE3C862D6D12BA005D520D",
"name" : "EssentialAppTests"
}
},
{
"target" : {
"containerPath" : "container:EssentialApp.xcodeproj",
"identifier" : "5BBDA0822D72983C00D68DF0",
"name" : "EssentialAppUIAcceptanceTests"
}
}
],
"version" : 1
Expand Down
118 changes: 2 additions & 116 deletions EssentialApp/EssentialApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
5BBDA0892D72983C00D68DF0 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 5BDE3C692D6D12B8005D520D /* Project object */;
proxyType = 1;
remoteGlobalIDString = 5BDE3C702D6D12B8005D520D;
remoteInfo = EssentialApp;
};
5BDE3C882D6D12BA005D520D /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 5BDE3C692D6D12B8005D520D /* Project object */;
Expand All @@ -48,7 +41,6 @@

/* Begin PBXFileReference section */
5BBD9FDF2D6EA59800D68DF0 /* CI_iOS.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = CI_iOS.xctestplan; sourceTree = "<group>"; };
5BBDA0832D72983C00D68DF0 /* EssentialAppUIAcceptanceTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = EssentialAppUIAcceptanceTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
5BDE3C712D6D12B8005D520D /* EssentialApp.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = EssentialApp.app; sourceTree = BUILT_PRODUCTS_DIR; };
5BDE3C872D6D12BA005D520D /* EssentialAppTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = EssentialAppTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
5BDE3CDF2D6D186D005D520D /* EssentialFeed.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = EssentialFeed.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Expand All @@ -67,11 +59,6 @@
/* End PBXFileSystemSynchronizedBuildFileExceptionSet section */

/* Begin PBXFileSystemSynchronizedRootGroup section */
5BBDA0842D72983C00D68DF0 /* EssentialAppUIAcceptanceTests */ = {
isa = PBXFileSystemSynchronizedRootGroup;
path = EssentialAppUIAcceptanceTests;
sourceTree = "<group>";
};
5BDE3C732D6D12B8005D520D /* EssentialApp */ = {
isa = PBXFileSystemSynchronizedRootGroup;
exceptions = (
Expand All @@ -88,13 +75,6 @@
/* End PBXFileSystemSynchronizedRootGroup section */

/* Begin PBXFrameworksBuildPhase section */
5BBDA0802D72983C00D68DF0 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
5BDE3C6E2D6D12B8005D520D /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
Expand All @@ -121,7 +101,6 @@
5BDE3D0C2D6D6092005D520D /* EssentialApp.xctestplan */,
5BDE3C732D6D12B8005D520D /* EssentialApp */,
5BDE3C8A2D6D12BA005D520D /* EssentialAppTests */,
5BBDA0842D72983C00D68DF0 /* EssentialAppUIAcceptanceTests */,
5BDE3CDE2D6D186D005D520D /* Frameworks */,
5BDE3C722D6D12B8005D520D /* Products */,
);
Expand All @@ -132,7 +111,6 @@
children = (
5BDE3C712D6D12B8005D520D /* EssentialApp.app */,
5BDE3C872D6D12BA005D520D /* EssentialAppTests.xctest */,
5BBDA0832D72983C00D68DF0 /* EssentialAppUIAcceptanceTests.xctest */,
);
name = Products;
sourceTree = "<group>";
Expand All @@ -149,29 +127,6 @@
/* End PBXGroup section */

/* Begin PBXNativeTarget section */
5BBDA0822D72983C00D68DF0 /* EssentialAppUIAcceptanceTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 5BBDA08B2D72983C00D68DF0 /* Build configuration list for PBXNativeTarget "EssentialAppUIAcceptanceTests" */;
buildPhases = (
5BBDA07F2D72983C00D68DF0 /* Sources */,
5BBDA0802D72983C00D68DF0 /* Frameworks */,
5BBDA0812D72983C00D68DF0 /* Resources */,
);
buildRules = (
);
dependencies = (
5BBDA08A2D72983C00D68DF0 /* PBXTargetDependency */,
);
fileSystemSynchronizedGroups = (
5BBDA0842D72983C00D68DF0 /* EssentialAppUIAcceptanceTests */,
);
name = EssentialAppUIAcceptanceTests;
packageProductDependencies = (
);
productName = EssentialAppUIAcceptanceTests;
productReference = 5BBDA0832D72983C00D68DF0 /* EssentialAppUIAcceptanceTests.xctest */;
productType = "com.apple.product-type.bundle.ui-testing";
};
5BDE3C702D6D12B8005D520D /* EssentialApp */ = {
isa = PBXNativeTarget;
buildConfigurationList = 5BDE3C9A2D6D12BA005D520D /* Build configuration list for PBXNativeTarget "EssentialApp" */;
Expand Down Expand Up @@ -228,10 +183,6 @@
LastSwiftUpdateCheck = 1620;
LastUpgradeCheck = 1620;
TargetAttributes = {
5BBDA0822D72983C00D68DF0 = {
CreatedOnToolsVersion = 16.2;
TestTargetID = 5BDE3C702D6D12B8005D520D;
};
5BDE3C702D6D12B8005D520D = {
CreatedOnToolsVersion = 16.2;
};
Expand All @@ -258,19 +209,11 @@
targets = (
5BDE3C702D6D12B8005D520D /* EssentialApp */,
5BDE3C862D6D12BA005D520D /* EssentialAppTests */,
5BBDA0822D72983C00D68DF0 /* EssentialAppUIAcceptanceTests */,
);
};
/* End PBXProject section */

/* Begin PBXResourcesBuildPhase section */
5BBDA0812D72983C00D68DF0 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
5BDE3C6F2D6D12B8005D520D /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
Expand All @@ -289,13 +232,6 @@
/* End PBXResourcesBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
5BBDA07F2D72983C00D68DF0 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
5BDE3C6D2D6D12B8005D520D /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
Expand All @@ -313,11 +249,6 @@
/* End PBXSourcesBuildPhase section */

/* Begin PBXTargetDependency section */
5BBDA08A2D72983C00D68DF0 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 5BDE3C702D6D12B8005D520D /* EssentialApp */;
targetProxy = 5BBDA0892D72983C00D68DF0 /* PBXContainerItemProxy */;
};
5BDE3C892D6D12BA005D520D /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 5BDE3C702D6D12B8005D520D /* EssentialApp */;
Expand All @@ -326,42 +257,6 @@
/* End PBXTargetDependency section */

/* Begin XCBuildConfiguration section */
5BBDA08C2D72983C00D68DF0 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 4VK5P5723H;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = portocode.EssentialAppUIAcceptanceTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
TEST_TARGET_NAME = EssentialApp;
};
name = Debug;
};
5BBDA08D2D72983C00D68DF0 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 4VK5P5723H;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = portocode.EssentialAppUIAcceptanceTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
TEST_TARGET_NAME = EssentialApp;
};
name = Release;
};
5BDE3C9B2D6D12BA005D520D /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
Expand Down Expand Up @@ -472,7 +367,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.2;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
Expand Down Expand Up @@ -529,7 +424,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 18.2;
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
Expand Down Expand Up @@ -583,15 +478,6 @@
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
5BBDA08B2D72983C00D68DF0 /* Build configuration list for PBXNativeTarget "EssentialAppUIAcceptanceTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
5BBDA08C2D72983C00D68DF0 /* Debug */,
5BBDA08D2D72983C00D68DF0 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
5BDE3C6C2D6D12B8005D520D /* Build configuration list for PBXProject "EssentialApp" */ = {
isa = XCConfigurationList;
buildConfigurations = (
Expand Down
3 changes: 0 additions & 3 deletions EssentialApp/EssentialApp.xcworkspace/contents.xcworkspacedata
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 0 additions & 60 deletions ...pp/EssentialApp.xcworkspace/xcshareddata/xcschemes/EssentialAppUIAcceptanceTests.xcscheme
View file
Open in desktop

This file was deleted.

14 changes: 2 additions & 12 deletions EssentialApp/EssentialApp/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import UIKit
@main
class AppDelegate: UIResponder, UIApplicationDelegate {



func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
// Override point for customization after application launch.
return true
Expand All @@ -20,21 +18,13 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
func application(_ application: UIApplication, configurationForConnecting connectingSceneSession: UISceneSession, options: UIScene.ConnectionOptions) -> UISceneConfiguration {
// Called when a new scene session is being created.
// Use this method to select a configuration to create the new scene with.
let configuration = UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role)

#if DEBUG
configuration.delegateClass = DebuggingSceneDelegate.self
#endif

return configuration
return UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role)
}

func application(_ application: UIApplication, didDiscardSceneSessions sceneSessions: Set<UISceneSession>) {
// Called when the user discards a scene session.
// If any sessions were discarded while the application was not running, this will be called shortly after application:didFinishLaunchingWithOptions.
// Use this method to release any resources that were specific to the discarded scenes, as they will not return.
}



}

Loading