This repository was archived by the owner on Aug 6, 2026. It is now read-only.
feat(loops): Add auto-fix PRs toggle and free wizard navigation - #3441
Closed
charlesvien wants to merge 2 commits into
Closed
feat(loops): Add auto-fix PRs toggle and free wizard navigation#3441charlesvien wants to merge 2 commits into
charlesvien wants to merge 2 commits into
Conversation
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "allow jumping to any loop wizard step" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| export function isAutoFixEnabled( | ||
| behaviors: LoopSchemas.LoopBehaviors, | ||
| ): boolean { | ||
| return behaviors.watch_ci && behaviors.fix_review_comments; |
Contributor
There was a problem hiding this comment.
When an existing loop has only watch_ci or fix_review_comments enabled, this predicate displays Auto-fix as Off even though one behavior remains active. Clicking the switch then enables both fields instead of disabling the active behavior, so the control and Review step misrepresent the persisted state.
Rule Used: When implementing new features, ensure that the UI... (source)
Learned From
PostHog/posthog#32595
PostHog/posthog#32677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Loops will eventually watch CI and review comments on the PRs they open and push fixes, but there's no way to opt a loop in yet. The wizard's step circles also blocked jumping ahead.
Changes
behaviorsobject on the loop model (watch_ci+fix_review_commentsset together); runtime behavior ships separately, this only persists the option. The Review step shows it as On/Off.Stacked on
feat/loops-- retargets to main once that merges.How did you test this?
pnpm --filter @posthog/ui typecheckand biome are clean.Automatic notifications