fix(billing): clarify org usage vs personal spend on Plan & usage - #3512
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
9755063 to
48d990a
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
48d990a to
e1c8b61
Compare
4b698f8 to
82b3e9c
Compare
e1c8b61 to
71e0c30
Compare
ee471f9 to
922de96
Compare
|
Reviews (1): Last reviewed commit: "fix(billing): frame the usage meter as o..." | Re-trigger Greptile |
922de96 to
3f365e9
Compare
adboio
added
the
Stamphog
Graphite App
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gates denied this PR because it touches billing code. The most significant change — hardcoding billingEnabled = true instead of reading from a feature flag — is a behavioral change to billing that bypasses the rollout gate and has zero reviews. This needs a human reviewer familiar with the billing rollout strategy before it can merge.
stamphog
Bot
removed
the
Stamphog
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
adboio
added
the
Stamphog
Graphite App
adboio
removed
the
Stamphog
There was a problem hiding this comment.
Gates denied this PR for touching billing code. Additionally, the diff removes the BILLING_FLAG and useFeatureFlag imports from PlanUsageSettings.tsx while the function body still references both — this is a broken build. The rest of the changes (label customization on formatResetTime, UI copy clarifications) are low-risk, but the import/usage mismatch and the billing gate failure require a human reviewer.
Merge activity
|
82b3e9c to
5229b7f
Compare
3b7e202 to
e143004
Compare
The Plan & usage page showed an org-level usage meter directly above a user-level spend analysis with no cue that the two have different scopes, so the spend numbers could read as the whole organization's. - Label the usage meter "Organization usage" with a caption noting it's shared across the whole organization (and "Your usage" for the per-user free-tier valve fallback). - Rename "Spend analysis" to "Your spend analysis" with a caption noting it covers only the signed-in user's usage. - Reword the org billing-period countdown from "Resets …" to "Billing period ends …" via an optional label on formatResetTime; kept "Resets" for the per-user free-tier valve windows, which really do reset. Generated-By: PostHog Code Task-Id: d69678da-415c-450b-aafe-3d834d0bc557
Free tier is per-org too — the gateway's per-user throttling is legacy and being removed — so there's no "your usage vs the org's usage" split to make. Drop the per-user branch on the usage meter: it's always "Organization usage" (shared across your whole organization), the true counterpart to the per-user "Your spend analysis" below. Generated-By: PostHog Code Task-Id: d69678da-415c-450b-aafe-3d834d0bc557
d73baea to
9913848
Compare
|
/trunk merge |
2 participants
Problem
it's not clear that usage is org-level, and spend analysis is user-level
Changes
updates the UI / copy a bit
How did you test this?
manually
Automatic notifications
Created with PostHog Code