Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

feat: group review files by type - #3526

Closed
MattPua wants to merge 1 commit into
mainfrom
posthog-code/group-code-review-files-by-type
Closed

feat: group review files by type#3526
MattPua wants to merge 1 commit into
mainfrom
posthog-code/group-code-review-files-by-type

Conversation

@MattPua

@MattPua MattPua commented Jul 16, 2026

Copy link
Copy Markdown
Member

Problem

Expanded code reviews only organize changed files by folder structure, which makes it harder to review implementation, tests, documentation, and generated files together.

Changes

  • Add a Folders / File type selector to the expanded review sidebar
  • Group files into implementation, tests, generated, documentation, configuration, assets, and other
  • Show full paths in type groups and detect common generated and test filename patterns
  • Add focused classification and ordering tests

Screenshots: not included for this compact sidebar control.

How did you test this?

  • pnpm --dir packages/ui exec vitest run src/features/task-detail/components/ChangesTreeView.test.ts
  • pnpm --filter @posthog/ui typecheck
  • pnpm exec biome lint packages/ui/src/features/task-detail/components/ChangesPanel.tsx packages/ui/src/features/task-detail/components/ChangesTreeView.tsx packages/ui/src/features/task-detail/components/ChangesTreeView.test.ts packages/ui/src/features/task-detail/components/changesTree.ts packages/ui/src/primitives/TreeDirectoryRow.tsx
  • Commit hooks ran pnpm typecheck

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 633af2d8-9f13-4a43-ac8e-673fc1d367d8
@trunk-io

trunk-io Bot commented Jul 16, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 89c5712.

@github-actions

Copy link
Copy Markdown

This PR has had no activity for 7 days and has been marked stale. We are moving to the monorepo and tightening PR staleness in preparation, so it will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale No recent changes to PR label Jul 24, 2026
@MattPua MattPua closed this Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

stale No recent changes to PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant