feat(git): play a producer tag sound when pushing to origin - #3628
feat(git): play a producer tag sound when pushing to origin#3628seanpem wants to merge 3 commits into
Conversation
Add a "Producer tag" setting under Notifications: pick a signature sound (built-in or an imported custom sound) that drops on a successful push, sync, or publish to the remote. - New producerTagSound/producerTagVolume settings, persisted and reset with the other notification defaults; orphaned custom-sound references are cleaned up alongside completionSound. - Trigger fires from the single push-success path in useGitInteraction, reusing the existing playCompletionSound helper (no-ops when "none"). - Extract a shared SoundSelect so the tag picker reuses the same pool as the completion sound. Generated-By: PostHog Code Task-Id: 70d325b0-91ae-442c-bbe2-63a84000bfdb
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Add a focused Storybook story that renders the real ProducerTagSection and Add-custom-sound dialog against the settings store, so the import-a-sound → select-as-tag → play flow can be demoed and visually reviewed without the authenticated app. Exports ProducerTagSection so the story can render it. Generated-By: PostHog Code Task-Id: 70d325b0-91ae-442c-bbe2-63a84000bfdb
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
The new Settings/ProducerTag story added 2 new visual snapshots, which fails the Visual Review check until a human approves them. It's a manual demo/record surface that doesn't need a signed baseline, so tag it "test-skip" — the Storybook test-runner skips it from snapshot capture. The story stays visible in Storybook for manual use. Generated-By: PostHog Code Task-Id: 70d325b0-91ae-442c-bbe2-63a84000bfdb
|
This PR has had no activity for 7 days and has been marked stale. We are moving to the monorepo and tightening PR staleness in preparation, so it will be closed in 7 days if no further activity occurs. |
|
Closing stale PRs ahead of Friday's monorepo migration. If this is a mistake, rebase and reopen for review. |
2 participants
Problem
For anyone who wants a bit of fun in their workflow: play a signature "producer tag" — a short sound of your choosing — every time you push code to origin, à la a music producer's drop.
Changes
applyPushResultinuseGitInteraction), so it fires on a successful push, sync, or publish. Reuses the existingplayCompletionSoundhelper, which no-ops when the tag is "None".SoundSelectso the tag picker and the completion-sound picker share one option list and the custom-sound pool.How did you test this?
pnpm --filter @posthog/ui typecheck— clean.biome linton the changed files — clean.pnpm --filter @posthog/ui exec vitest runover the settings and git-interaction suites — 97 passing, including new store tests for the producer-tag setters, orphan cleanup on custom-sound removal, persistence, and rehydrate normalization.Automatic notifications
Created with PostHog Code