Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix: require structured blocking questions - #3762

Merged
trunk-io[bot] merged 4 commits into
mainfrom
posthog-code/enforce-structured-blocking-questions
Jul 23, 2026
Merged

fix: require structured blocking questions#3762
trunk-io[bot] merged 4 commits into
mainfrom
posthog-code/enforce-structured-blocking-questions

Conversation

@MattPua

@MattPua MattPua commented Jul 23, 2026

Copy link
Copy Markdown
Member

Problem

Agents can end a turn with a plain-text blocking question, causing the task to appear finished instead of waiting for user input.

Changes

  • Require AskUserQuestion for blocking questions in the default system prompt
  • Add regression coverage for the prompt guidance

How did you test this?

  • pnpm exec biome check packages/workspace-server/src/services/agent/agent.ts packages/workspace-server/src/services/agent/agent.test.ts
  • pnpm --filter @posthog/workspace-server exec vitest run src/services/agent/agent.test.ts
  • pnpm --filter @posthog/workspace-server typecheck
  • Pre-commit pnpm typecheck

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

MattPua added 2 commits July 23, 2026 11:10
Generated-By: PostHog Code
Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
Generated-By: PostHog Code
Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
@trunk-io

trunk-io Bot commented Jul 23, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit dc0d803.

@MattPua
MattPua marked this pull request as ready for review July 23, 2026 15:13
Generated-By: PostHog Code
Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix: document question tools for both ad..." | Re-trigger Greptile

Generated-By: PostHog Code
Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
@trunk-io
trunk-io Bot merged commit 48346e1 into main Jul 23, 2026
33 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/enforce-structured-blocking-questions branch July 23, 2026 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants