This repository was archived by the owner on Aug 6, 2026. It is now read-only.
fix: require structured blocking questions - #3762
Merged
trunk-io[bot] merged 4 commits intoJul 23, 2026
Merged
Conversation
Generated-By: PostHog Code Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
Generated-By: PostHog Code Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
MattPua
marked this pull request as ready for review
July 23, 2026 15:13
Generated-By: PostHog Code Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
Contributor
|
Reviews (1): Last reviewed commit: "fix: document question tools for both ad..." | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: 1b1b8d63-c777-47f5-9fa9-3a15479a627f
tatoalo
approved these changes
Jul 23, 2026
trunk-io
Bot
deleted the
posthog-code/enforce-structured-blocking-questions
branch
July 23, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agents can end a turn with a plain-text blocking question, causing the task to appear finished instead of waiting for user input.
Changes
AskUserQuestionfor blocking questions in the default system promptHow did you test this?
pnpm exec biome check packages/workspace-server/src/services/agent/agent.ts packages/workspace-server/src/services/agent/agent.test.tspnpm --filter @posthog/workspace-server exec vitest run src/services/agent/agent.test.tspnpm --filter @posthog/workspace-server typecheckpnpm typecheckAutomatic notifications
Created with PostHog Code