feat(loops): Add Rafa's geometric hero background to promo card - #3780
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/loops/components/LoopsPromoCard.tsx:228
**Dialog fade uses undefined token**
When the Loops dialog opens, this gradient targets `--background`, but the shared light and dark themes define `--color-background`; the invalid endpoint leaves the intended fade absent and the blue hero ends abruptly against the dialog body.
Reviews (1): Last reviewed commit: "add geometric hero background to loops p..." | Re-trigger Greptile |
There was a problem hiding this comment.
Purely presentational change to a single UI promo card (SVG background, hover/dismiss styling) with no business logic, API, auth, billing, or dependency surface touched; author has STRONG familiarity with this exact file. The one open concern is a minor CSS variable typo affecting a decorative gradient, not a showstopper.
- Author wrote 100% of the modified lines and has 7 merged PRs in these paths (familiarity STRONG).
- greptile-apps[bot] reviewed the current head.
- Dialog gradient uses
to-(--background), but only--color-backgroundis defined in globals.css — the fade likely renders as a hard cutoff instead of blending into the dialog body. Cosmetic only (Greptile's inline comment on this, marked resolved, doesn't appear actually fixed in the diff) — not a functional or security issue.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 98L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1b-small (98L, 1F, single-area, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 883dc3f · reviewed head 44e6336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Introducing Loops promo card and dialog sit on a flat gray panel, which reads as placeholder next to the product push cards in the PostHog app.
Rafa made a cool thing that looked similar to what I built so I wanted to use his geometric background from his design https://posthog.slack.com/archives/C09G8Q32R6F/p1784806145720579
Changes
Copies the hero background Rafa built for the product push cards in PostHog/posthog#67968: a solid product color with scattered white geometric shapes and a gradient fade into the card body. Both the sidebar mini card and the announcement dialog use it, on the product analytics blue. The card hover switches from a background tint to a shadow lift and the dismiss button adopts the same white-on-scrim style as the source cards.
How did you test this?
turbo run typecheck --filter=@posthog/ui, both cleanvitest run src/features/loopsin packages/ui, 89 tests passAutomatic notifications