feat(loops): Allow editing loop metadata inline - #3847
Closed
MattPua wants to merge 3 commits into
Closed
Conversation
Generated-By: PostHog Code Task-Id: beb0b035-943b-4a49-a2e4-04b47c3cbf07
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
MattPua
changed the title
Match the display typography and give the edit field room so long titles are not clipped. Generated-By: PostHog Code Task-Id: beb0b035-943b-4a49-a2e4-04b47c3cbf07
QA pass on the inline title/description editors: - Extract the triplicated save-on-blur state machine (title, description, instructions) into useInlineEdit, closing the drift where the new editors lacked the isPending guard. - Description Enter now inserts a newline instead of committing, matching the instructions textarea; single-line title still commits on Enter. - Add title tooltip for truncated names. - Bump empty-description placeholder to the gray-10 muted-text token. - Cover the hook with tests. Generated-By: PostHog Code Task-Id: beb0b035-943b-4a49-a2e4-04b47c3cbf07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Why: Loop titles and descriptions can only be changed through the full edit flow, making small metadata updates unnecessarily slow.
Changes
How did you test this?
pnpm --filter @posthog/ui typecheckpnpm --filter @posthog/ui test src/features/loops(186 tests)pnpm exec biome check --write packages/ui/src/features/loops/components/LoopDetailView.tsxAutomatic notifications
Created with PostHog Code