Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix: show all task PRs in artifacts pane - #3873

Merged
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/show-all-task-pr-artifacts
Jul 29, 2026
Merged

fix: show all task PRs in artifacts pane#3873
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/show-all-task-pr-artifacts

Conversation

@puemos

@puemos puemos commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Problem

Tasks that create multiple pull requests only show the primary PR in the artifacts pane.

Changes

Read the run’s accumulated PR URL list when building artifact rows, while retaining legacy singular-field compatibility.

How did you test this?

  • pnpm exec vitest run src/features/canvas/components/TaskArtifactsList.test.tsx (10 tests passed)
  • pnpm exec biome check src/features/canvas/components/TaskArtifactsList.tsx src/features/canvas/components/TaskArtifactsList.test.tsx

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 6a40abe6-f02f-44f3-b1a4-c7348d1bdfd8
@trunk-io

trunk-io Bot commented Jul 28, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit d091f0d.

@puemos
puemos marked this pull request as ready for review July 28, 2026 12:45
@puemos puemos self-assigned this Jul 28, 2026
@puemos
puemos requested a review from a team July 28, 2026 12:45
@posthog

posthog Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🦔 ReviewHog reviewed this pull request

Nothing worth raising this time, so here's a calming picture instead:

A happy dog on a sunny path

@trunk-io
trunk-io Bot merged commit ac50479 into main Jul 29, 2026
35 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/show-all-task-pr-artifacts branch July 29, 2026 08:37
Gilbert09 added a commit that referenced this pull request Jul 29, 2026
Mobile read a task run's PR only from `output.pr_url`, so runs that record PRs in `output.pr_urls` (the increasingly canonical field, and the only field for multi-PR runs) showed no PR link or status icon. Route all three surfaces — the task detail header, the task list PR badge, and the status-icon kind — through the shared `readPrUrls` helper so they honor both fields, matching the desktop fix.

Generated-By: PostHog Code
Task-Id: ffe12b00-92c7-4b99-9d63-99de687ad8ec
Gilbert09 added a commit that referenced this pull request Jul 29, 2026
Mobile read a task run's PR only from `output.pr_url`, so runs that record PRs in `output.pr_urls` (the increasingly canonical field, and the only field for multi-PR runs) showed no PR link or status icon. Route all three surfaces — the task detail header, the task list PR badge, and the status-icon kind — through the shared `readPrUrls` helper so they honor both fields, matching the desktop fix.

Generated-By: PostHog Code
Task-Id: ffe12b00-92c7-4b99-9d63-99de687ad8ec
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants