Skip to content

fix(loops): resolve creators on channel pages - #3877

Merged
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/fix-channel-loop-creator
Jul 28, 2026
Merged

fix(loops): resolve creators on channel pages#3877
trunk-io[bot] merged 1 commit into
mainfrom
posthog-code/fix-channel-loop-creator

Conversation

@MattPua

@MattPua MattPua commented Jul 28, 2026

Copy link
Copy Markdown
Member

Problem

Channel-attached loops showed active creators as former organization members because the page did not resolve loop owners.

Why: Creator attribution should stay consistent between the main Loops page and channel Loops tabs.

Changes

Resolve organization members for attached loops and pass creator lookup state to each loop row.

How did you test this?

  • pnpm biome check packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsx
  • pnpm build:deps
  • pnpm --filter @posthog/ui typecheck
  • pnpm --filter @posthog/ui test -- --run packages/ui/src/features/loops/components/LoopsListView.test.tsx (2,298 tests passed)

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 0c9b7c4b-7245-4b38-8c6d-89936934eaf4
@trunk-io

trunk-io Bot commented Jul 28, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 7387b77.

@MattPua
MattPua marked this pull request as ready for review July 28, 2026 15:08
@MattPua MattPua added the Stamphog This will request an autostamp by stamphog on small changes label Jul 28, 2026
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(loops): resolve creators on channel ..." | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, contained UI fix passing creator lookup data into an existing component; no risky territory touched.

  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 18L, 1F substantive — within ceiling
tier T1-agent / T1a-trivial (18L, 1F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 2a074aa · reviewed head 7387b77

@trunk-io
trunk-io Bot merged commit 659c5be into main Jul 28, 2026
40 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/fix-channel-loop-creator branch July 28, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant