fix(git): handle missing remote branch comparisons - #3881
Merged
Conversation
Generated-By: PostHog Code Task-Id: 1d6efd63-cb24-47c2-aa8b-b05239df349f
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
marked this pull request as ready for review
July 28, 2026 15:47
tatoalo
added
the
Stamphog
Contributor
|
Reviews (1): Last reviewed commit: "fix(git): handle missing remote branch c..." | Re-trigger Greptile |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Small, contained fix in workspace-server's git service treating a 404 from branch comparison as an empty diff, with new regression tests; not risky territory (no auth, billing, data model, deps, or CI changes) and diff matches the stated description.
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 3L, 1F substantive, 90L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (90L, 2F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 943ba3b · reviewed head e7d17dc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cloud runs can expose their branch name before the branch has been pushed to GitHub. Polling the compare endpoint during that window returns 404 and produces repeated internal errors in the development console.
Changes
Treat a 404 from the branch comparison as an empty diff while preserving all other failures. Add regression coverage for missing branches, successful comparisons, and non-404 errors