Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix: include PR titles in generated task names - #3892

Merged
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/include-pr-title-in-task-names
Jul 28, 2026
Merged

fix: include PR titles in generated task names#3892
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/include-pr-title-in-task-names

Conversation

@MattPua

@MattPua MattPua commented Jul 28, 2026

Copy link
Copy Markdown
Member

Problem

Tasks created from existing GitHub PRs get generic names that omit the PR title.

Changes

  • Tell task-name generation to include the existing PR number and title
  • Add regression coverage for the generation prompt

How did you test this?

  • pnpm exec vitest run packages/core/src/sessions/titleGeneratorService.test.ts
  • pnpm typecheck
  • pnpm exec prettier --check packages/core/src/sessions/titleGeneratorService.ts packages/core/src/sessions/titleGeneratorService.test.ts

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@trunk-io

trunk-io Bot commented Jul 28, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 6267549.

Generated-By: PostHog Code
Task-Id: 0c226c8d-1b4d-4527-8d8c-2c0819279f10
@MattPua
MattPua force-pushed the posthog-code/include-pr-title-in-task-names branch from b116ae6 to 4e932fb Compare July 28, 2026 18:04
@MattPua
MattPua marked this pull request as ready for review July 28, 2026 19:25
Comment thread packages/core/src/sessions/titleGeneratorService.ts
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
### Issue 1
packages/core/src/sessions/titleGeneratorService.ts:43
**PR title corrupts summary framing**

When an existing PR title contains `SUMMARY:`, the new verbatim-copy rule places that delimiter inside the generated `TITLE:` line. The unanchored summary parser then starts inside the PR title, causing malformed conversation-summary context to be stored and used for later commit and PR generation.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix: include PR titles in generated task..." | Re-trigger Greptile

@MattPua
MattPua marked this pull request as draft July 28, 2026 19:31
Generated-By: PostHog Code
Task-Id: 511823aa-fc4e-4f54-8064-cc1cecf38807
@MattPua
MattPua marked this pull request as ready for review July 28, 2026 19:42
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "fix: anchor generated summary parsing" | Re-trigger Greptile

@trunk-io
trunk-io Bot merged commit af8d1ce into main Jul 28, 2026
39 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/include-pr-title-in-task-names branch July 28, 2026 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants