fix(agent): hide effort controls for Kimi sessions - #3935
Merged
Conversation
Generated-By: PostHog Code Task-Id: e18a8b14-426f-437f-98e2-db55475ea06e
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
marked this pull request as ready for review
July 29, 2026 11:25
Contributor
|
Reviews (1): Last reviewed commit: "fix(agent): hide effort controls for Kim..." | Re-trigger Greptile |
tatoalo
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Small, contained fix that assigns the resolved model id before building config options so Kimi sessions correctly hide unsupported effort controls; verified against surrounding code, includes a matching test, and touches no risky territory.
- Author wrote 0% of the modified lines and has 27 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 1L, 1F substantive, 22L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (22L, 2F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ afb8fd5 · reviewed head 9a945d7 |
jonathanlab
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Kimi K3 does not support selectable effort levels. New tasks correctly omit the selector, but a running session could show the default model's effort controls because its config was built from stale model state.
Why: Selecting one of those invalid values can make a later task request fail validation
Changes
Build session config from the model actually resolved for execution, so Kimi sessions keep the effort control hidden