Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

trunk-merge/pr-3928/835a350c-c231-4714-bc27-eb62ef88753d - #3946

Closed
trunk-io[bot] wants to merge 3 commits into
mainfrom
trunk-merge/pr-3928/835a350c-c231-4714-bc27-eb62ef88753d
Closed

trunk-merge/pr-3928/835a350c-c231-4714-bc27-eb62ef88753d#3946
trunk-io[bot] wants to merge 3 commits into
mainfrom
trunk-merge/pr-3928/835a350c-c231-4714-bc27-eb62ef88753d

Conversation

@trunk-io

@trunk-io trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown
Trunk Merge Pull Request Banner

This pull request was created and is being managed by Trunk Merge.

This pull request is based on the main branch at SHA d2aa7b7e6af09f7582f537ce01ef47a030baea37.

See more details here.

When CI completes, this pull request will be closed automatically.

Pull Requests Being Tested

This pull request is testing the changes from pull request 3928.

Gilbert09 and others added 3 commits July 29, 2026 11:41
EAS Build defaults to Node v20.19.4, but node-gyp@12.4.0 pulls in
undici@8.4.1 which requires Node >=22.19.0. On the builder this fails
at install time with "webidl.util.markAsUncloneable is not a function",
taking down every native postinstall (node-pty, better-sqlite3) and
aborting the INSTALL_DEPENDENCIES phase.

CI never caught it because GitHub Actions runs Node 22, so the local
pnpm install succeeds and only the remote EAS install fails. Broken
since node-gyp 12.4.0 entered the lockfile in #2795.
@posthog/shared exposes itself via `exports` pointing at dist/, which
only exists after a pnpm build. EAS Build never runs one and dist/ is
gitignored so it is not uploaded either, so Metro bundling fails there
with an unresolvable main field.

metro.config.js already meant to sidestep this by aliasing the package
to its TypeScript source, but extraNodeModules never fired: pnpm
symlinks the package into apps/mobile/node_modules, so Metro resolves
it there first and never consults the alias. It also cannot express
subpath imports -- @posthog/shared/domain-types was being rewritten to
the nonexistent src/index.ts/domain-types.

Replace it with a resolveRequest hook that maps the package and its
subpaths onto packages/shared/src.
@trunk-io trunk-io Bot closed this Jul 29, 2026
@trunk-io
trunk-io Bot deleted the trunk-merge/pr-3928/835a350c-c231-4714-bc27-eb62ef88753d branch July 29, 2026 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant