trunk-merge/pr-3952/f0457a77-6df2-40b4-a93d-a0f8181a4b8a - #3955
Closed
trunk-io[bot] wants to merge 4 commits into
Closed
trunk-merge/pr-3952/f0457a77-6df2-40b4-a93d-a0f8181a4b8a#3955trunk-io[bot] wants to merge 4 commits into
trunk-io[bot] wants to merge 4 commits into
Conversation
The agent slug becomes a subdomain label in the ingress URL (`<slug>.agents.<region>.posthog.com`), but it arrived from an `?agent=` approval deep link and was interpolated without any validation, so a slug that isn't a plain label could change where the resulting request goes. Validate it as a single DNS label in two places: the deep-link handler drops a malformed slug so the link falls back to the fleet Approvals inbox, and `agentIngressBaseUrl` returns null rather than interpolating one, which keeps callers on their existing "no ingress" path.
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
trunk-io
Bot
deleted the
trunk-merge/pr-3952/f0457a77-6df2-40b4-a93d-a0f8181a4b8a
branch
July 29, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 271fe9b3098774ddae97a73c129b92a65a34c8b3.
See more details about each PR in the batch here:
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing a batch with the changes from pull requests 3952 and 3954 - batching documentation.