trunk-merge/pr-3887/a1cfe480-377d-4656-bdd2-e4b72df08385 - #4009
Closed
trunk-io[bot] wants to merge 3 commits into
Closed
trunk-merge/pr-3887/a1cfe480-377d-4656-bdd2-e4b72df08385#4009trunk-io[bot] wants to merge 3 commits into
trunk-io[bot] wants to merge 3 commits into
Conversation
… names Slack-originated PRs could @-mention/tag a GitHub account derived from the requester's Slack display name, tagging an unrelated user. The cloud prompt had no guard against this — the only mention guidance was Slack-specific. Adds a shared "Never guess a GitHub identity" instruction to every PR-body block, and bridges the Slack "# Mentioning users" section to make clear those tokens are Slack-only and a Slack handle is not a GitHub username. Generated-By: PostHog Code Task-Id: 036db1f3-626b-464f-a62f-6ef923fcb29c
Addresses Greptile review feedback: a handle appearing in git history / CODEOWNERS / existing PRs proves the handle exists, not that it belongs to the Slack requester. Restrict the allowed source of a GitHub @mention to a handle the user gave explicitly in-thread, and spell out that repository presence is not identity verification. Generated-By: PostHog Code Task-Id: 036db1f3-626b-464f-a62f-6ef923fcb29c
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
trunk-io
Bot
deleted the
trunk-merge/pr-3887/a1cfe480-377d-4656-bdd2-e4b72df08385
branch
July 30, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 531056a2bafdacfbad7fe3cccb5803a10d138782.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 3887.