Skip to content

Remove task header launcher menus #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 3 commits into from
Jul 30, 2026
Merged

Remove task header launcher menus #4013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ddf37e
Remove external app header opener
k11kirky Jul 30, 2026
8b00517
Remove quick prompt header menu
k11kirky Jul 30, 2026
5d4856c
chore(visual): update storybook baselines
posthog[bot] Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions apps/code/snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,10 +692,6 @@ snapshots:
hash: v1.k4693efd2.e747a3b5d0983a7a125335f1d95cc7735dafda73abdb3f63ccfadde0482c5ce9.tjc4lMKeaOJjLLxd9tivmgKLshzHZwuSAa_MbqwN_20
skill-buttons-skillbuttonactionmessage--run-experiment--light:
hash: v1.k4693efd2.c18264887c67224ea1196646ff27f31ef9d79add87b5e9dfead377fcaf0dc941.MwzR7Yyd4le31Qm7RB2yk-qLk5ujgLkN-cMAB2WQ9_k
skill-buttons-skillbuttonsmenu--default--dark:
hash: v1.k4693efd2.cfff4c6bbb0acef1c9941b21d2f69c24b234c2c206282acf6fcada0cb2bd2386.xILjVPp8ecQmGbPjGDdhbRyi9KFPpA_1nfYF3bfjwuc
skill-buttons-skillbuttonsmenu--default--light:
hash: v1.k4693efd2.eb9bd49b9700641f6f3c90653447c9767c52e997afec9843e8649b90752faad3.VdxEtBwtkU3ioy2evcNbrEKxPjQ1GDUpZAQzFe-Uho4
spaces-taskfeedrow--agent-origin--dark:
hash: v1.k4693efd2.82f8c70a399c9ea768201933e202fcc2fde74332c5153aeabf6835ace79beee6.yEZq_qnKxItv5u0Ydcqa1B4VCwv8lwXUvcaFScE2XO0
spaces-taskfeedrow--agent-origin--light:
Expand Down
9 changes: 0 additions & 9 deletions packages/shared/src/analytics-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export type SkillButtonId =
| "add-error-tracking"
| "instrument-llm-calls"
| "add-logging";
type SkillButtonSource = "primary" | "dropdown";
export type CommandMenuAction =
| "home"
| "new-task"
Expand Down Expand Up @@ -289,12 +288,6 @@ export interface BrainrotActivatedProperties {
filled_cells: number;
}

export interface SkillButtonTriggeredProperties {
task_id: string;
button_id: SkillButtonId;
source: SkillButtonSource;
}

// Settings events
export interface SettingChangedProperties {
setting_name: string;
Expand Down Expand Up @@ -1319,7 +1312,6 @@ export const ANALYTICS_EVENTS = {
COMMAND_MENU_ACTION: "Command menu action",
COMMAND_CENTER_VIEWED: "Command center viewed",
BRAINROT_ACTIVATED: "Brainrot activated",
SKILL_BUTTON_TRIGGERED: "Skill button triggered",
POSTHOG_WEB_OPENED: "PostHog web opened",
SIDEBAR_NAV_ITEM_CLICKED: "Sidebar nav item clicked",
SIDEBAR_CUSTOMIZED: "Sidebar customized",
Expand Down Expand Up @@ -1498,7 +1490,6 @@ export type EventPropertyMap = {
[ANALYTICS_EVENTS.COMMAND_MENU_ACTION]: CommandMenuActionProperties;
[ANALYTICS_EVENTS.COMMAND_CENTER_VIEWED]: never;
[ANALYTICS_EVENTS.BRAINROT_ACTIVATED]: BrainrotActivatedProperties;
[ANALYTICS_EVENTS.SKILL_BUTTON_TRIGGERED]: SkillButtonTriggeredProperties;
[ANALYTICS_EVENTS.POSTHOG_WEB_OPENED]: never;
[ANALYTICS_EVENTS.SIDEBAR_NAV_ITEM_CLICKED]: SidebarNavItemClickedProperties;
[ANALYTICS_EVENTS.SIDEBAR_CUSTOMIZED]: SidebarCustomizedProperties;
Expand Down
16 changes: 0 additions & 16 deletions packages/ui/src/features/command/keyboard-shortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ export const SHORTCUTS = {
// takes slot 1 instead.
SWITCH_STARRED_CHANNEL:
"mod+1,mod+2,mod+3,mod+4,mod+5,mod+6,mod+7,mod+8,mod+9",
OPEN_IN_EDITOR: "mod+o",
COPY_PATH: "mod+shift+c",
TOGGLE_FOCUS: "mod+r",
PASTE_AS_FILE: "mod+shift+v",
INBOX: "mod+i",
Expand Down Expand Up @@ -211,20 +209,6 @@ export const KEYBOARD_SHORTCUTS: KeyboardShortcut[] = [
category: "panels",
context: "Task detail",
},
{
id: "open-in-editor",
keys: SHORTCUTS.OPEN_IN_EDITOR,
description: "Open in external editor",
category: "panels",
context: "Task detail",
},
{
id: "copy-path",
keys: SHORTCUTS.COPY_PATH,
description: "Copy file path",
category: "panels",
context: "Task detail",
},
{
id: "find-in-conversation",
keys: SHORTCUTS.FIND_IN_CONVERSATION,
Expand Down
18 changes: 0 additions & 18 deletions packages/ui/src/features/skill-buttons/components/SkillButtonsMenu.stories.tsx
View file
Open in desktop

This file was deleted.

109 changes: 0 additions & 109 deletions packages/ui/src/features/skill-buttons/components/SkillButtonsMenu.tsx
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions packages/ui/src/features/skill-buttons/skillButtonsStore.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/ui/src/features/skills/SkillDetailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import type { SkillInfo } from "@posthog/shared";
import { stripFrontmatter } from "@posthog/shared";
import { CodeMirrorEditor } from "@posthog/ui/features/code-editor/components/CodeMirrorEditor";
import { MarkdownRenderer } from "@posthog/ui/features/editor/components/MarkdownRenderer";
import { ExternalAppsOpener } from "@posthog/ui/features/task-detail/components/ExternalAppsOpener";
import { toast } from "@posthog/ui/primitives/toast";
import {
AlertDialog,
Expand Down Expand Up @@ -298,9 +297,6 @@ export function SkillDetailPanel({
Import
</Button>
)}
{skill.source !== "bundled" && (
<ExternalAppsOpener targetPath={skill.path} />
)}
</Flex>

{issues.length > 0 && (
Expand Down
Loading
Loading