fix(ci): tolerate lockfile drift in vr-cli install - #4029
Merged
Conversation
|
😎 This pull request was merged. |
Contributor
|
Reviews (1): Last reviewed commit: "tolerate lockfile drift in vr-cli instal..." | Re-trigger Greptile |
charlesvien
force-pushed
the
fix/vr-cli-lockfile-drift
branch
from
July 31, 2026 02:16
cf5252c to
3a6a5d5
Compare
arnohillen
added a commit
that referenced
this pull request
Aug 1, 2026
Picks up the vr-cli install fix from #4029 so the visual-regression check passes. Generated-By: PostHog Code Task-Id: 58678630-1e4b-4565-9de0-c74c91b9d995
arnohillen
added a commit
that referenced
this pull request
Aug 1, 2026
Picks up the vr-cli install fix from #4029 so the visual-regression check passes. Generated-By: PostHog Code Task-Id: 58678630-1e4b-4565-9de0-c74c91b9d995
arnohillen
added a commit
that referenced
this pull request
Aug 1, 2026
Picks up the vr-cli install fix from #4029 so the visual-regression check passes. Generated-By: PostHog Code Task-Id: 58678630-1e4b-4565-9de0-c74c91b9d995
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The visual-regression job builds the Visual Review CLI from posthog master's checkout, unpinned. posthog#74334 bumped sharp there with a lockfile that does not resolve on Linux, so
npm cifails and every PR in this repo goes red on visual-regression until the upstream lockfile is fixed (posthog#75785 is open but not merged).Changes
Fall back to
npm installwhennpm cifails in the Install Visual Review CLI step. The step installs a tool, not a reproducible build artifact, so regenerating the lock at install time is safe. Once upstream is fixed,npm cisucceeds again and the fallback is dormant.How did you test this?
The identical change ran on #4028 earlier today:
npm cifailed with the lockfile error,npm installtook over and the job passed (https://github.com/PostHog/code/actions/runs/30596738872/job/91050657268).Automatic notifications