trunk-merge/pr-3944/5f4b302c-49b6-4dec-b2a1-c762e33c1c94 - #4045
Closed
trunk-io[bot] wants to merge 5 commits into
Closed
trunk-merge/pr-3944/5f4b302c-49b6-4dec-b2a1-c762e33c1c94#4045trunk-io[bot] wants to merge 5 commits into
trunk-io[bot] wants to merge 5 commits into
Conversation
Add guidance to the cloud task system prompt instructing the agent to call the `upload_artifact` tool for non-code deliverables (reports, images, rendered canvases, data files) so they appear in the user's artifact panel as downloads, rather than being left in the workspace where the user can't see them. The instruction is appended to every cloud system-prompt branch and skipped for Slack-origin sessions, which get a runtime "no artifact delivery" constraint. Exposes UPLOAD_ARTIFACT_QUALIFIED_TOOL_NAME from the tool module, mirroring the signed-commit tool-name constants, so the prompt references the qualified tool id from a single source. Generated-By: PostHog Code Task-Id: 887b21b0-78b0-4741-be7c-1f0e456f926a
Address review feedback from @k11kirky: drop the exported UPLOAD_ARTIFACT tool-name constants (revert upload-artifact.ts to referencing the literal name), remove the verbose explanatory code comment, and tighten the artifact-delivery prompt prose. The instruction now references the `upload_artifact` tool by its short name. Generated-By: PostHog Code Task-Id: 887b21b0-78b0-4741-be7c-1f0e456f926a
Address review feedback from @puemos: drop the Slack gating so the artifact-delivery instruction appears in every cloud session. Sessions that genuinely can't deliver artifacts already get a runtime constraint that overrides the prompt. Generated-By: PostHog Code Task-Id: 887b21b0-78b0-4741-be7c-1f0e456f926a
Generated-By: PostHog Code Task-Id: 842d598b-48cc-4059-8fed-18a9965a71c4
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
trunk-io
Bot
deleted the
trunk-merge/pr-3944/5f4b302c-49b6-4dec-b2a1-c762e33c1c94
branch
July 31, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA d117c82be9d54ce8d632460612d3262cbba3f05f.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 3944.